Use BatchSpanProcessor instead of SimpleSpanProcessor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2020 08:50
This change updates all opentelemetry-go dependencies to v0.12.0
As reported by @milanaleksic, the launcher was configured to use the SimpleSpanProcessor which was affecting application performance. This change updates the launcher to configure the BatchSpanProcessor by default. Fixes #21
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 93.44% 93.49% +0.05%
==========================================
Files 3 3
Lines 244 246 +2
==========================================
+ Hits 228 230 +2
Misses 8 8
Partials 8 8
Continue to review full report at Codecov.
|
kayousterhout
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @milanaleksic, the launcher was configured to use the
SimpleSpanProcessorwhich was affecting application performance. This change updates the launcher to configure theBatchSpanProcessorby default.Fixes #21
Note: This PR is built on top of #23, will update the PR once that other change is merged.