Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement min/max for the expo-histogram #215

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Implement min/max for the expo-histogram #215

merged 2 commits into from
Jul 11, 2022

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Jul 8, 2022

Description: The OTLP v0.18 protocol added min/max fields. This code was last written to v0.16 which lacked the necessary fields to complete this.

Testing: Existing test coverage was extended.

@jmacd jmacd requested a review from jaronoff97 July 8, 2022 20:38
@codecov-commenter
Copy link

Codecov Report

Merging #215 (e3a09ed) into main (e1ddd9c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   94.33%   94.35%   +0.02%     
==========================================
  Files          62       62              
  Lines        3263     3297      +34     
==========================================
+ Hits         3078     3111      +33     
- Misses        141      142       +1     
  Partials       44       44              
Impacted Files Coverage Δ
...p/sdk/metric/aggregator/aggregation/aggregation.go 95.12% <ø> (ø)
...tep/sdk/metric/aggregator/histogram/exponential.go 95.85% <100.00%> (+0.29%) ⬆️
...tstep/sdk/metric/aggregator/histogram/histogram.go 98.16% <100.00%> (+0.14%) ⬆️
.../exporters/otlp/internal/metrictransform/metric.go 97.01% <100.00%> (+0.13%) ⬆️
...etric/exporters/otlp/internal/otlptest/otlptest.go 97.70% <100.00%> (+0.07%) ⬆️
examples/metrics/metrics.go 84.05% <0.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ddd9c...e3a09ed. Read the comment docs.

@codeboten codeboten merged commit f391a22 into main Jul 11, 2022
@codeboten codeboten deleted the jmacd/histminmax branch July 11, 2022 17:01
jmacd added a commit to lightstep/go-expohisto that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants