-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Asynchronous and Synchronous state packages for review LS-29754 #173
Add the Asynchronous and Synchronous state packages for review LS-29754 #173
Conversation
…launcher-go into alt_metrics_sdk/review_internalstate
Reviewers: as discussed last week, there was still a TODO about a race condition; the synchronous-instrument delta-temporality collector was not correctly synchronized for deletion to occur from its map. This could have been repaired in at least two ways; I chose the one that IMO is better, but this is subtle. This change is shown in the following commit: This needs more documentation and can use further testing, however it resolves the races and TODO. The design is as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but nothing blocking. 💯
Description:
The internal/syncstate and internal/asyncstate package contain the adapters used by the MeterProvider to the viewstate package's compiler. The syncstate package, in particular, handles the hot code path used by synchronous instruments.
Link to tracking Issue:
LS-29760 describes the overall goal; this is one part.
Testing:
End-to-end testing was done. The alt_metrics_sdk/development branch has a assembled copy of this code. Depends on various Lightstep-side PRs merging to see the exponential histograms work.