Skip to content

Commit

Permalink
Update OTelCol exporter names used by metrics/trace SDKs (#480)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmacd authored Jun 16, 2023
1 parent 6ed7e08 commit d4fc8b9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions lightstep/sdk/metric/exporters/otlp/otelcol/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ func NewExporter(ctx context.Context, cfg Config) (metric.PushExporter, error) {
c := &client{}

if !cfg.Exporter.Arrow.Disabled {
c.settings.ID = component.NewID("otlp/arrow")
c.settings.ID = component.NewID("otel/sdk/arrow")
} else {
c.settings.ID = component.NewID("otlp/proto")
c.settings.ID = component.NewID("otel/sdk/otlp")
}
logger, err := zap.NewProduction()
if err != nil {
Expand All @@ -158,7 +158,7 @@ func NewExporter(ctx context.Context, cfg Config) (metric.PushExporter, error) {
}

bset := processor.CreateSettings{
ID: component.NewID("otlp/batch"),
ID: component.NewID("otel/sdk/batch"),
TelemetrySettings: c.settings.TelemetrySettings,
BuildInfo: c.settings.BuildInfo,
}
Expand Down
6 changes: 3 additions & 3 deletions lightstep/sdk/trace/exporters/otlp/otelcol/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ func NewExporter(ctx context.Context, cfg Config) (trace.SpanExporter, error) {
c := &client{}

if !cfg.Exporter.Arrow.Disabled {
c.settings.ID = component.NewID("otlp/arrow")
c.settings.ID = component.NewID("otel/sdk/arrow")
} else {
c.settings.ID = component.NewID("otlp/proto")
c.settings.ID = component.NewID("otel/sdk/otlp")
}
logger, err := zap.NewProduction()
if err != nil {
Expand All @@ -165,7 +165,7 @@ func NewExporter(ctx context.Context, cfg Config) (trace.SpanExporter, error) {
}

bset := processor.CreateSettings{
ID: component.NewID("otlp/batch"),
ID: component.NewID("otel/sdk/batch"),
TelemetrySettings: c.settings.TelemetrySettings,
BuildInfo: c.settings.BuildInfo,
}
Expand Down

0 comments on commit d4fc8b9

Please sign in to comment.