Skip to content

Fix PHP 8.4 deprecation warnings and upgrade PHPUnit #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TomA-R wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP 8.4 deprecation warnings and upgrade PHPUnit #64

TomA-R wants to merge 1 commit into from

Conversation

@TomA-R
Copy link
Contributor

@TomA-R TomA-R commented Dec 2, 2024

Fix deprecation warnings like:

Deprecated: LightStepBase\Client\Transports\TransportUDP::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in lightstep/tracer/lib/Client/Transports/TransportUDP.php on line 19
Deprecated: LightStepBase\Client\Transports\TransportHTTPJSON::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in lightstep/tracer/lib/Client/Transports/TransportHTTPJSON.php on line 22
Deprecated: LightStepBase\Client\Transports\TransportHTTPPROTO::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in tracer/lib/Client/Transports/TransportHTTPPROTO.php on line 22

Upgrade PHPUnit

To a version that can be used with modern versions of PHP

Screenshot 2024-12-02 at 23 07 13

bc-chenli
bc-chenli approved these changes Dec 18, 2024
View reviewed changes
Copy link

@bc-chenli bc-chenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bc-chenli bc-chenli bc-chenli approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomA-R @bc-chenli