Skip to content

cleanup-branches.yml has invalid YAML (missing steps: key), breaking lint:yaml for every PR #1074

Closed

Description

@ashleyshaw

Describe the bug

.github/workflows/cleanup-branches.yml, introduced in #1067, is missing the steps: key under the cleanup job. The env: mapping is immediately followed by a - name: Checkout repository list item with no steps: parent key, which is invalid YAML.

Because npm run lint:all runs spectral lint '**/*.{yml,yaml}' across the whole repo (not just changed files), this breaks the lint job - and therefore the required All Checks Passed status check - for every PR into develop, regardless of what the PR actually touches. Found while trying to get an unrelated PR (#1073) green.

To Reproduce

  1. npm run lint:all on current develop
  2. See parser errors at .github/workflows/cleanup-branches.yml:37-46 ("Bad indentation of a mapping entry", "Can not read a block mapping entry")

Expected behavior

cleanup-branches.yml parses as valid YAML and npm run lint:all passes.

Additional Context

Fix: insert steps: before the - name: Checkout repository line, at the same indentation as the job's other top-level keys (runs-on, env).

Definition of Ready (DoR)

  • Bug is reproducible and clearly described
  • Steps to reproduce written
  • Linked to existing issues/PRs (if any)
  • Ready for triage

Definition of Done (DoD)

  • Bug confirmed and reproducible
  • Fix implemented and verified
  • Documentation updated (if needed)
  • Changelog entry prepared for PR (CHANGELOG.md)
  • Linked issue closed

Activity

  1. linear-code commented on Jul 22, 2026

    @linear-code
  2. github-actions commented on Jul 22, 2026

    @github-actions
    Contributor

    ✅ Template check passed after update. Thanks for fixing the issue body.

  3. ashleyshaw commented on Jul 22, 2026

    @ashleyshaw
    MemberAuthor

    Fixed by #1075 (merged: a3a327c). GitHub's auto-close via the "Closes #1074" reference didn't fire despite correctly recognizing the link (confirmed via the GraphQL closingIssuesReferences field) — closing manually.

  4. ashleyshaw commented on Jul 22, 2026

    @ashleyshaw
    MemberAuthor

    Re-closing. The prior reopen appears to have used a stale/delayed workflow run evaluating the issue as it was before the DoR/DoD sections were added and the status:needs-more-info label removed. Current body and labels meet the close requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions