Nit: removed unacessible statement

[tisnik]

Description

Nit: removed unacessible statement

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Summary by CodeRabbit

• Bug Fixes
  • Streaming responses no longer stop after an error in a chunk; subsequent events continue to be delivered.
  • Ensures you still receive turn status updates, tool/inference events, and heartbeats alongside error notifications.
  • Delivers more complete and consistent event streams during partial failures, improving the continuity of live updates.

[coderabbitai]

Walkthrough

Removed an early return in stream_build_event within src/app/endpoints/streaming_query.py so that, after emitting an error event, the function continues evaluating event_type and step_type to dispatch standard SSE events for the same chunk.

Changes

Cohort / File(s)	Summary
Streaming event handling src/app/endpoints/streaming_query.py	Removed early return after error emission in stream_build_event; error chunks can now also emit standard SSE events (turn_start, turn_complete, shield_call, inference, tool_execution, heartbeat). No public signatures changed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant Server
  participant stream_build_event

  Client->>Server: Request SSE stream
  loop For each chunk
    Server->>stream_build_event: Process chunk
    alt Chunk has error
      stream_build_event-->>Server: Emit error SSE
      Note right of stream_build_event: Early return removed
      opt Continue dispatch
        stream_build_event-->>Server: Emit turn_start/turn_complete/...
        stream_build_event-->>Server: Emit shield_call/inference/tool_execution/heartbeat
      end
    else No error
      stream_build_event-->>Server: Emit standard SSE(s)
    end
    Server-->>Client: Stream SSE(s)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Streaming improvements #254 — Also modifies stream_build_event to adjust error handling and multi-event emission behavior.

Suggested reviewers

• jrobertboos
• umago

Poem

Thump-thump goes my reviewer’s heart,
Errors no longer tear apart—
Streams now flow with extra cheer,
Events keep hopping, crystal clear.
I twitch my nose, approve the art,
More hops per chunk—SSE smart!
(_/)> 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 49c4e58 and ea2b2c5.

📒 Files selected for processing (1)

• src/app/endpoints/streaming_query.py (0 hunks)

💤 Files with no reviewable changes (1)

• src/app/endpoints/streaming_query.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build-pr
• GitHub Check: e2e_tests

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.