Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/app/endpoints/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ async def query_endpoint_handler(
store_transcript(
user_id=user_id,
conversation_id=conversation_id,
model_id=model_id,
provider_id=provider_id,
query_is_valid=True, # TODO(lucasagomes): implement as part of query validation
query=query_request.query,
query_request=query_request,
Expand Down Expand Up @@ -456,6 +458,8 @@ def construct_transcripts_path(user_id: str, conversation_id: str) -> Path:
def store_transcript( # pylint: disable=too-many-arguments,too-many-positional-arguments
user_id: str,
conversation_id: str,
model_id: str,
provider_id: str | None,
query_is_valid: bool,
query: str,
query_request: QueryRequest,
Expand All @@ -482,8 +486,10 @@ def store_transcript( # pylint: disable=too-many-arguments,too-many-positional-

data_to_store = {
"metadata": {
"provider": query_request.provider,
"model": query_request.model,
"provider": provider_id,
"model": model_id,
"query_provider": query_request.provider,
"query_model": query_request.model,
"user_id": user_id,
"conversation_id": conversation_id,
"timestamp": datetime.now(UTC).isoformat(),
Expand Down
2 changes: 2 additions & 0 deletions src/app/endpoints/streaming_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,8 @@ async def response_generator(turn_response: Any) -> AsyncIterator[str]:
store_transcript(
user_id=user_id,
conversation_id=conversation_id,
model_id=model_id,
provider_id=provider_id,
query_is_valid=True, # TODO(lucasagomes): implement as part of query validation
query=query_request.query,
query_request=query_request,
Expand Down
10 changes: 8 additions & 2 deletions tests/unit/app/endpoints/test_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ async def _test_query_endpoint_handler(mocker, store_transcript_to_file=False):
mock_transcript.assert_called_once_with(
user_id="mock_user_id",
conversation_id=conversation_id,
model_id="fake_model_id",
provider_id="fake_provider_id",
query_is_valid=True,
query=query,
query_request=query_request,
Expand Down Expand Up @@ -1045,6 +1047,8 @@ def test_store_transcript(mocker):
store_transcript(
user_id,
conversation_id,
model,
provider,
query_is_valid,
query,
query_request,
Expand All @@ -1058,8 +1062,10 @@ def test_store_transcript(mocker):
mock_json.dump.assert_called_once_with(
{
"metadata": {
"provider": query_request.provider,
"model": query_request.model,
"provider": "fake-provider",
"model": "fake-model",
"query_provider": query_request.provider,
"query_model": query_request.model,
"user_id": user_id,
"conversation_id": conversation_id,
"timestamp": mocker.ANY,
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/app/endpoints/test_streaming_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ async def _test_streaming_query_endpoint_handler(mocker, store_transcript=False)
mock_transcript.assert_called_once_with(
user_id="mock_user_id",
conversation_id="test_conversation_id",
model_id="fake_model_id",
provider_id="fake_provider_id",
query_is_valid=True,
query=query,
query_request=query_request,
Expand Down