-
Notifications
You must be signed in to change notification settings - Fork 70
LCORE-336: update dependencies excluding OpenAI #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tisnik
merged 1 commit into
lightspeed-core:main
from
tisnik:lcore-336-update-dependencies-excluding-openai
Aug 10, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Remove OpenAI addition; it contradicts PR scope (LCORE-336).
PR explicitly says “update dependencies excluding OpenAI,” but this adds a new runtime dep
openai==1.99.1. Please drop this change from this PR or move it to a separate, explicitly scoped PR. If OpenAI is needed, consider placing it in a non-core dependency group (e.g., an optional group) rather than the core runtime deps.Apply this diff to revert for this PR:
- "openai==1.99.1",Optionally, if needed in a separate PR, prefer an optional group:
To ensure the pinned version exists on PyPI before introducing it in a follow-up PR, run:
🏁 Script executed:
Length of output: 117
Remove OpenAI from core dependencies
The scope of LCORE-336 is to update existing dependencies — it explicitly excludes adding OpenAI. This PR introduces a new runtime dependency (
openai==1.99.1), so please revert that change here or move it into its own, optional dependency group in a follow-up PR (we’ve confirmedopenai==1.99.1exists on PyPI).• File:
pyproject.toml• Line: 36
Suggested diff to revert in this PR:
- "openai==1.99.1",If you still need OpenAI in a separate PR, consider:
📝 Committable suggestion
🤖 Prompt for AI Agents