LCORE-470: initalize agent in query

[maorfr]

similar to #349, but for query

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability by ensuring agents are fully initialized before use.

[coderabbitai]

Walkthrough

A call to agent.initialize() was added directly after the creation of the Agent instance within the get_agent function in src/app/endpoints/query.py. This change ensures explicit initialization of the agent before proceeding with subsequent logic. No other logic or control flow was modified.

Changes

Cohort / File(s)	Change Summary
Agent Initialization Update src/app/endpoints/query.py	Added explicit call to agent.initialize() after creating the Agent instance in get_agent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip, the agent awakes,
With .initialize() now, no mistakes!
Rabbits rejoice, the code is quite neat,
Ready to run, no need to repeat.
In the warren of logic, all’s in its place—
Initialization brings a smile to my face! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5afee1 and 9b89aac.

📒 Files selected for processing (1)

• src/app/endpoints/query.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: e2e_tests
• GitHub Check: build-pr

🔇 Additional comments (1)

src/app/endpoints/query.py (1)

99-101: Avoid creating & deleting an “orphan” agent – call initialize() only when you really need a fresh remote agent

agent.initialize() unconditionally spins up a brand-new remote agent.
When a conversation_id is supplied and the corresponding agent exists (the common happy path), the code then immediately:

1. overwrites agent.agent_id with the requested conversation_id; and
2. deletes the freshly-created “orphan” agent (client.agents.delete(orphan_agent_id)).

That means every request with an existing conversation now performs an unnecessary network round-trip (create → delete), adding latency and load on Llama-Stack and increasing chances of race conditions if the delete fails.

-    agent.initialize()
+    # Only create a new remote agent when we did **not** find an existing one
+    # for the supplied conversation_id.
+    if existing_agent_id is None:
+        agent.initialize()

This keeps the previous behaviour for new conversations while eliminating the redundant create/delete cycle for ongoing ones.
[ suggest_essential_refactor ]

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[eranco74]

Note that I consolidated get_agent for query and streaming_query in #348

[manstis]

LGTM 👍

Out of curiosity, was the call removed during a refactor or never existed?