Skip to content

LCORE-1206add extra e2e tests to align with OLS#1091

Merged
radofuchs merged 1 commit intolightspeed-core:mainfrom
radofuchs:E2E_OLS_Alignment
Feb 2, 2026
Merged

LCORE-1206add extra e2e tests to align with OLS#1091
radofuchs merged 1 commit intolightspeed-core:mainfrom
radofuchs:E2E_OLS_Alignment

Conversation

@radofuchs
Copy link
Contributor

@radofuchs radofuchs commented Feb 2, 2026

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #LCORE-1206
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Tests
    • Enhanced test coverage for query error scenarios, including invalid conversation IDs, unknown models/providers, and connectivity issues.
    • Added validation tests for attachment handling in queries.
    • Expanded streaming query error handling test cases for model and provider validation.

@radofuchs radofuchs requested a review from tisnik February 2, 2026 08:49
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Walkthrough

The pull request modifies two end-to-end BDD test feature files to add and reorganize test scenarios for error conditions. Changes include tests for incorrect conversation ID format, unknown models and providers, connectivity failures, missing query parameters, and missing field combinations, along with attachment handling validation.

Changes

Cohort / File(s) Summary
Query Error Scenarios
tests/e2e/features/query.feature
Removed one test scenario; added tests for 422 improper conversation ID, 404 unknown model/provider, 503 llama-stack connectivity failure, 422 missing query, and 422 missing model/provider combinations; added scenario for attachment handling (XML/JSON) returning 200; reorganized scenarios under skip-in-library-mode.
Streaming Query Error Scenarios
tests/e2e/features/streaming_query.feature
Added two new test scenarios for 404 unknown model and 404 unknown provider errors when querying the streaming\_query endpoint.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #745: Adds scenarios for unknown model/provider errors and related streaming-query test behaviors.
  • #997: Adds end-to-end test assertions for 404 "model does not exist" error scenarios in query.feature.
  • #425: Introduces initial e2e feature tests for both query.feature and streaming_query.feature.

Suggested reviewers

  • tisnik
  • are-ces
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to adding extra e2e tests to align with OLS, which directly matches the changeset of adding new test scenarios to query and streaming_query feature files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoaoFula
Copy link
Contributor

JoaoFula commented Feb 2, 2026

LGTM

@radofuchs radofuchs merged commit 8361b37 into lightspeed-core:main Feb 2, 2026
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants