fix: use sqlalchemy[asyncio] to ensure greenlet on all platforms#50
Open
shanemcd wants to merge 1 commit intolightspeed-core:mainfrom
Open
fix: use sqlalchemy[asyncio] to ensure greenlet on all platforms#50shanemcd wants to merge 1 commit intolightspeed-core:mainfrom
shanemcd wants to merge 1 commit intolightspeed-core:mainfrom
Conversation
SQLAlchemy's base dependencies specify greenlet with platform markers that exclude s390x. Since we use async SQLAlchemy features (via llama-stack), we need greenlet at runtime on all platforms. The [asyncio] extra includes greenlet unconditionally, fixing s390x builds that were failing with "No module named 'greenlet'". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
sqlalchemy[asyncio]>=2.0.0instead ofsqlalchemy>=2.0.0to ensure greenlet is installed on all platforms.SQLAlchemy's base dependencies specify greenlet with platform markers that exclude s390x. Since we use async SQLAlchemy features (via llama-stack), we need greenlet at runtime on all platforms.
The
[asyncio]extra includes greenlet unconditionally, fixing s390x builds that were failing with "No module named 'greenlet'".Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing