Conversation
romartin
approved these changes
Dec 19, 2025
de1987
approved these changes
Dec 19, 2025
Tool Definition is using tool_name instead of name. Signed-off-by: Djebran Lezzoum <ldjebran@gmail.com>
6ac94d9 to
1950150
Compare
Contributor
Author
|
fixed unitest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool Definition is using tool_name instead of name.
https://github.com/llamastack/llama-stack/blob/e710622d4c03c8a4549a93f70c993f22d0676910/src/llama_stack/models/llama/datatypes.py#L85
https://github.com/llamastack/llama-stack/blob/release-0.2.22/llama_stack/providers/inline/agents/meta_reference/agent_instance.py#L793
Description
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing