Skip to content

fix sample data#69

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
asamal4:fix-sample-data
Oct 7, 2025
Merged

fix sample data#69
tisnik merged 1 commit intolightspeed-core:mainfrom
asamal4:fix-sample-data

Conversation

@asamal4
Copy link
Collaborator

@asamal4 asamal4 commented Oct 7, 2025

Fix sample data.

Summary by CodeRabbit

  • Documentation

    • Clarified Usage Scenarios with guidance to modify system.yaml and evaluation_data.yaml; noted that evaluation_data.yaml includes sample data for reference.
  • Chores

    • Updated sample evaluation_data.yaml by setting the first turn’s attachments in conv_group_1 from an empty list to null for consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Walkthrough

Documentation was updated with explicit guidance in two README usage sections. In config/evaluation_data.yaml, the first turn of conv_group_1 changed the attachments field from an empty list to null. No code, logic, or control flow changes.

Changes

Cohort / File(s) Summary
Documentation updates
README.md
Added explicit instruction text under two "Usage Scenarios" sections regarding modifying system.yaml and evaluation_data.yaml and noting sample data presence.
Configuration data tweak
config/evaluation_data.yaml
For conv_group_1 first turn, changed attachments from [] to null; no other data altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • tisnik

Poem

A nibble of notes, a YAML hop,
From [] to null—plop, plop!
README whispers clearer now,
“Tweak your configs,” take a bow.
Ears up, docs tidy, data small—
Thump-thump! I reviewed it all. 🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “fix sample data” succinctly captures the main purpose of the pull request, namely correcting the sample data in the evaluation_data.yaml file, without extraneous wording. It uses clear, imperative phrasing and directly relates to the changes made.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e695669 and ca7d503.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • config/evaluation_data.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: mypy
🔇 Additional comments (1)
config/evaluation_data.yaml (1)

11-11: Confirm consumer tolerance for attachments: null.

The schema docs still describe attachments as a list. Switching this sample to null will surface None to any loader that iterates without guarding, which would previously see an empty list. Please double-check that the evaluation pipeline (and any schema validation) explicitly allows null here; otherwise revert to [] or drop the key entirely to keep the sample aligned with the declared type.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@VladimirKadlec VladimirKadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit fe532aa into lightspeed-core:main Oct 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants