Conversation
Contributor
|
@VladimirKadlec PTAL |
asamal4
force-pushed
the
some-lint-fix1
branch
3 times, most recently
from
69f6555 to
a86fbc9
Compare
Collaborator
Author
|
@tisnik @VladimirKadlec PTAL and merge.. |
VladimirKadlec
approved these changes
Jul 10, 2025
Contributor
VladimirKadlec
left a comment
VladimirKadlec
left a comment
There was a problem hiding this comment.
Two minor comments, looks good 💪
| def _get_recent_response( | ||
| self, question, recent_resp_df, provider, model, eval_mode | ||
| ): # pylint: disable=R0913,R0917 | ||
| def _get_recent_response( # pylint: disable=R0913,R0917 |
Contributor
There was a problem hiding this comment.
is disabling pylint checks still needed?
Collaborator
Author
There was a problem hiding this comment.
yes..
- either we need to change threshold for arguments in pylint setting.
- or restructure the code/logic to reduce number of parameters
| def calculate_scores(self, query, answer, response): # pylint: disable=R0914 | ||
| def calculate_scores( # type: ignore[no-untyped-def] | ||
| self, query: str, answer: str, response: str | ||
| ): # pylint: disable=R0914 |
Contributor
There was a problem hiding this comment.
is disabling pylint checks still needed?
Collaborator
Author
There was a problem hiding this comment.
same comment as above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.