Skip to content

remove dynamic __all__#116

Merged
asamal4 merged 1 commit intolightspeed-core:mainfrom
asamal4:remove-dynamic-all
Dec 11, 2025
Merged

remove dynamic __all__#116
asamal4 merged 1 commit intolightspeed-core:mainfrom
asamal4:remove-dynamic-all

Conversation

@asamal4
Copy link
Collaborator

@asamal4 asamal4 commented Dec 9, 2025

Description

Remove dynamic all to avoid pyright warnings. This is not required.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Unit tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

Release Notes

  • Refactor
    • Internal restructuring of module export declarations across the package. No changes to functionality or user-facing features.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Walkthrough

Removed __all__ declarations from 8 package __init__.py files across the lightspeed_evaluation codebase. The lazy import mechanism via __getattr__ remains unchanged. This affects wildcard import behavior while preserving lazy loading functionality.

Changes

Cohort / File(s) Summary
Root package exports
src/lightspeed_evaluation/__init__.py
Removed __all__ declaration
Core submodule exports
src/lightspeed_evaluation/core/{api,llm,metrics,output,script}/__init__.py
Removed __all__ = list(_LAZY_IMPORTS.keys()) from 5 core module init files
Pipeline module exports
src/lightspeed_evaluation/pipeline/__init__.py,
src/lightspeed_evaluation/pipeline/evaluation/__init__.py
Removed __all__ declarations from 2 pipeline-related init files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Highly repetitive, homogeneous pattern across all 8 files (identical type of deletion)
  • Simple structural change to export declarations with no logic modifications
  • No behavioral changes to lazy import mechanism or runtime behavior

Possibly related PRs

Suggested reviewers

  • VladimirKadlec
  • tisnik

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'remove dynamic all' directly and accurately describes the primary change across all modified files: the systematic removal of all declarations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 659d90c and a1e6da0.

📒 Files selected for processing (8)
  • src/lightspeed_evaluation/__init__.py (0 hunks)
  • src/lightspeed_evaluation/core/api/__init__.py (0 hunks)
  • src/lightspeed_evaluation/core/llm/__init__.py (0 hunks)
  • src/lightspeed_evaluation/core/metrics/__init__.py (0 hunks)
  • src/lightspeed_evaluation/core/output/__init__.py (0 hunks)
  • src/lightspeed_evaluation/core/script/__init__.py (0 hunks)
  • src/lightspeed_evaluation/pipeline/__init__.py (0 hunks)
  • src/lightspeed_evaluation/pipeline/evaluation/__init__.py (0 hunks)
💤 Files with no reviewable changes (8)
  • src/lightspeed_evaluation/core/llm/init.py
  • src/lightspeed_evaluation/core/metrics/init.py
  • src/lightspeed_evaluation/core/output/init.py
  • src/lightspeed_evaluation/pipeline/init.py
  • src/lightspeed_evaluation/pipeline/evaluation/init.py
  • src/lightspeed_evaluation/core/script/init.py
  • src/lightspeed_evaluation/core/api/init.py
  • src/lightspeed_evaluation/init.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: mypy
  • GitHub Check: tests (3.13)
  • GitHub Check: tests (3.11)
  • GitHub Check: tests (3.12)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@VladimirKadlec VladimirKadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@asamal4 asamal4 merged commit decc14d into lightspeed-core:main Dec 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants