Skip to content

DEVOPS-2782-lightrun-agents-helm-chart-add-new-field-of-workload-name #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

DEVOPS-2782-lightrun-agents-helm-chart-add-new-field-of-workload-name #47

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac194a9
Update Lightrun agents configuration to introduce `workloadName` and …
May 25, 2025
8ce1f3f
Fix pr comments
Jun 3, 2025
121d0bd
Merge branch 'main' into DEVOPS-2782-lightrun-agents-helm-chart-add-n…
imeliran Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pr comments
  • Loading branch information
eliranb committed Jun 3, 2025
commit 8ce1f3ff99c65f999a360f32b4daa4cd4b6bad28
9 changes: 0 additions & 9 deletions charts/lightrun-agents/templates/_checkConfig.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,6 @@ Compile all warnings into a single message, and call fail.
{{- $objectErrorMsgs = append $objectErrorMsgs "Workload Configuration Checker:\n Error: No workload configuration specified. Please provide either 'deploymentName' (legacy) OR 'workloadName' with 'workloadType' (recommended)." -}}
{{- end }}

{{- /* Validate workloadType if workloadName is provided */}}
{{- if .workloadName }}
{{- if not .workloadType }}
{{- $objectErrorMsgs = append $objectErrorMsgs "Workload Type Checker:\n Error: 'workloadName' is specified but 'workloadType' is missing. Please provide 'workloadType' (either 'Deployment' or 'StatefulSet')." -}}
{{- else if not (or (eq .workloadType "Deployment") (eq .workloadType "StatefulSet")) }}
{{- $objectErrorMsgs = append $objectErrorMsgs "Workload Type Checker:\n Error: Invalid 'workloadType' value. Must be either 'Deployment' or 'StatefulSet'." -}}
{{- end }}
{{- end }}

{{- if not .containerSelector }}
{{- $objectErrorMsgs = append $objectErrorMsgs "Container Selector Checker:\n Error: The 'containerSelector' field is missing. Please provide the 'containerSelector' parameter." -}}
{{- end }}
Expand Down
Loading