DEVOPS-2693-lightrun-k-8-s-operator-add-ability-to-set-image-pull-policy-for-init-container #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshiko-s
reviewed
May 28, 2025
charts/lightrun-agents/README.md
Outdated
| | `javaAgents[].containerSelector` | Selector for containers within the deployment to inject the Lightrun Java Agent. | Required | | ||
| | `javaAgents[].deploymentName` | Name of the Kubernetes deployment to attach the Lightrun Java Agent. | Required | | ||
| | `javaAgents[].initContainer.image` | Image for the Lightrun Java Agent init container. | Required | | ||
| | `javaAgents[].initContainer.imagePullPolicy` | Image pull policy for the init container. Can be one of: Always, IfNotPresent, or Never. | Optional (if not provided, defaults to `"IfNotPresent"`) | |
There was a problem hiding this comment.
the default depends on the image tag, no?
I would provide a link to the official docs
| spec: | ||
| initContainer: | ||
| image: {{ .initContainer.image }} | ||
| imagePullPolicy: {{ .initContainer.imagePullPolicy | default "IfNotPresent" }} |
There was a problem hiding this comment.
can't we omit it if not provided? to use k8s defaults
…ity-to-set-image-pull-policy-for-init-container
moshiko-s
previously approved these changes
Jun 11, 2025
…-operator-add-ability-to-set-image-pull-policy-for-init-container
moshiko-s
approved these changes
Jun 11, 2025
imeliran
deleted the
DEVOPS-2693-lightrun-k-8-s-operator-add-ability-to-set-image-pull-policy-for-init-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.