webapi: derive SVG prototype chains#3012
Merged
Merged
Conversation
This was referenced Jul 22, 2026
mh0pe
force-pushed
the
codex/svg-01-factory
branch
2 times, most recently
from
July 22, 2026 13:03
89130a8 to
ee878e9
Compare
mh0pe
marked this pull request as ready for review
July 22, 2026 13:11
Contributor
Author
karlseguin
force-pushed
the
codex/svg-01-factory
branch
from
July 23, 2026 00:58
ee878e9 to
7140cfa
Compare
Collaborator
|
Looks fine to me. I didn't look at the other SVG changes planned, but I understand why this is helpful. You might want to rebase those before opening since the Zig 0.16 merge requires it (I've rebased this one). Just waiting for the CI to finish, but I need to step out for ~1 hour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_protowalkercreateElementNSThis reauthors the factory-chain subset of #2157 on top of the SVG hierarchy merged in #2917 instead of replaying the obsolete implementation.
Atomic stack
Dependent units are ready for review and remain stacked on their preceding branch history so every owning commit stays explicit.
Validation
mainat6f82bdcdzig fmtpassedThe workflow aggregate is red only because the fork cannot pull the private
ghcr.io/lightpanda-io/perf-fmtcontainer; that job executed no repository code.