Skip to content

webapi: derive SVG prototype chains#3012

Merged
karlseguin merged 1 commit into
lightpanda-io:mainfrom
mh0pe:codex/svg-01-factory
Jul 23, 2026
Merged

webapi: derive SVG prototype chains#3012
karlseguin merged 1 commit into
lightpanda-io:mainfrom
mh0pe:codex/svg-01-factory

Conversation

@mh0pe

@mh0pe mh0pe commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace three fixed-depth SVG factory helpers with one compile-time _proto walker
  • preserve SVG tag casing and namespace while initializing arbitrary graphics and geometry chains
  • add hierarchy coverage for parser-created nodes and createElementNS

This reauthors the factory-chain subset of #2157 on top of the SVG hierarchy merged in #2917 instead of replaying the obsolete implementation.

Atomic stack

  1. webapi: derive SVG prototype chains #3012 — prototype-chain foundation
  2. webapi: add live SVG scalar values #3034 — live scalar values
  3. webapi: add live SVG collections #3030 — live collections
  4. webapi: implement SVG geometry #3033 — geometry and paths
  5. webapi: add SVG structural elements #3031 — structural elements
  6. webapi: add live SVG resource elements #3029 — resource elements
  7. webapi: add dependency-free SVG text DOM #3032 — dependency-free text DOM

Dependent units are ready for review and remain stacked on their preceding branch history so every owning commit stays explicit.

Validation

The workflow aggregate is red only because the fork cannot pull the private ghcr.io/lightpanda-io/perf-fmt container; that job executed no repository code.

@mh0pe
mh0pe force-pushed the codex/svg-01-factory branch 2 times, most recently from 89130a8 to ee878e9 Compare July 22, 2026 13:03
@mh0pe
mh0pe marked this pull request as ready for review July 22, 2026 13:11
@mh0pe

mh0pe commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@pinetops @staylor could I get a review please?

@karlseguin
karlseguin force-pushed the codex/svg-01-factory branch from ee878e9 to 7140cfa Compare July 23, 2026 00:58
@karlseguin

Copy link
Copy Markdown
Collaborator

@pinetops @staylor could I get a review please?

Looks fine to me. I didn't look at the other SVG changes planned, but I understand why this is helpful. You might want to rebase those before opening since the Zig 0.16 merge requires it (I've rebased this one).

Just waiting for the CI to finish, but I need to step out for ~1 hour.

@karlseguin
karlseguin merged commit 0d77c50 into lightpanda-io:main Jul 23, 2026
25 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants