fix(api): clean up bad JSON noise and fix progress bar going backwards#165
Conversation
Added links to Modly and Lightning Pixel on X for updates.
Change error message format for JSON decoding failure.
|
You’ll need to pull the dev branch and resolve the conflicts. |
Added a sponsors section to acknowledge early supporters.
|
In your PR, there are changes to the README, package.json, and main.py files. |
|
Ok sounds good! I think those were from an online dev change I was doing. Ill look at them and rid them asap :) |
|
I have two branches that Ive made so far. The progress-logging 'shouldn't' have anything in there related to the feature 1 changes, if thats what the updates are about? The branch transform-gizmo has those. Sorry I am confused. Its a newbie thing lol. So Im trying to commit the progress-logging branch. Those should ONLY have those in there that I changed. What do I do exactly because Im not sure what needs to be removed I apologize :(. I should probably stick to just making extensions because this is a lot for me to understand under my conditions. BUT I hope I can fix it because the transform gizmo is awesome :) |
Updated README to reflect changes in CLI commands and community section.
iammojogo-sudo
left a comment
iammojogo-sudo
left a comment
There was a problem hiding this comment.
I believe I fixed the changes needed.
|
You’ll need to remove the current changes in the README.md file, and after that it should be all good :) |
Was this fixed or no? lol |
This PR is scoped to JSON noise cleanup and the progress-bar fix; the README edits (Modly CLI section, launcher.bat rename) are out of scope and have been reverted to keep the diff focused.
lightningpixel
force-pushed
the
fix/progress-logging
branch
from
92013ef to
90344f8
Compare
4 participants
Two small backend fixes.
First, when an extension's generator.py prints anything to stdout — debug
lines, tqdm bars, torch loading messages — it was showing up in the logs
as "[model] bad JSON: " on every single one. The lines weren't
malformed, they were just plain text that isn't part of the JSON protocol.
They now get forwarded to stderr as normal extension output instead.
Second, the progress bar could visibly snap backwards during generation.
The model loading phase slowly walks progress up to around 7%, but then
the extension starts its own generation and reports 0% first, resetting it.
Added a simple guard so progress can only move forward, never back.