Skip to content

fix(generate): remove ambient lighting #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lightningpixel merged 1 commit into from
Apr 21, 2026
Merged

fix(generate): remove ambient lighting #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/areas/generate/GeneratePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,13 @@ function DecimatePopover({
// ---------------------------------------------------------------------------

export interface LightSettings {
ambientIntensity: number
ambientColor: string
mainIntensity: number
mainColor: string
fillIntensity: number
fillColor: string
}

export const DEFAULT_LIGHT_SETTINGS: LightSettings = {
ambientIntensity: 1.2,
ambientColor: '#ffffff',
mainIntensity: 1.5,
mainColor: '#ffffff',
fillIntensity: 0.6,
Expand Down Expand Up @@ -196,7 +192,6 @@ function LightPopover({
Reset
</button>
</div>
{lightRow('Ambient', 'ambientColor', 'ambientIntensity', 3)}
{lightRow('Sun', 'mainColor', 'mainIntensity', 4)}
{lightRow('Fill', 'fillColor', 'fillIntensity', 2)}
<button
Expand Down
3 changes: 1 addition & 2 deletions src/areas/generate/components/Viewer3D.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,7 @@ export default function Viewer3D({ lightSettings = DEFAULT_LIGHT_SETTINGS }: { l

{modelUrl && currentJob ? (
<Suspense fallback={null}>
<hemisphereLight args={[lightSettings.ambientColor, '#444466', lightSettings.ambientIntensity]} />
<directionalLight position={[5, 8, 5]} color={lightSettings.mainColor} intensity={lightSettings.mainIntensity} castShadow />
<directionalLight position={[5, 8, 5]} color={lightSettings.mainColor} intensity={lightSettings.mainIntensity} castShadow />
<directionalLight position={[-4, 2, -4]} color={lightSettings.fillColor} intensity={lightSettings.fillIntensity} />
<MeshModel
url={modelUrl}
Expand Down