Skip to content

POC Payment SQL Support#9822

Closed
ziggie1984 wants to merge 2 commits intolightningnetwork:masterfrom
ziggie1984:preparework-payments
Closed

POC Payment SQL Support#9822
ziggie1984 wants to merge 2 commits intolightningnetwork:masterfrom
ziggie1984:preparework-payments

Conversation

@ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented May 18, 2025

POC of the Payment SQL support for payments.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 18, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ziggie1984 ziggie1984 force-pushed the preparework-payments branch from ce8445f to 4049209 Compare May 18, 2025 21:28
@ziggie1984 ziggie1984 added payments Related to invoices/payments refactoring labels May 19, 2025
@ziggie1984 ziggie1984 added this to the v0.20.0 milestone May 19, 2025
@ziggie1984 ziggie1984 self-assigned this May 19, 2025
@ziggie1984 ziggie1984 added the code health Related to code commenting, refactoring, and other non-behaviour improvements label May 19, 2025
@ziggie1984 ziggie1984 changed the title Refactor Payments Code (1|?) Refactor Payments Code (Head PR for refactor to make sure the itest pass) May 19, 2025
@saubyk saubyk moved this to In progress in lnd v0.20 May 22, 2025
@ziggie1984 ziggie1984 force-pushed the preparework-payments branch from 4049209 to 09e05ff Compare July 14, 2025 07:36
@ziggie1984 ziggie1984 force-pushed the preparework-payments branch from 0042a60 to dabf3ae Compare July 15, 2025 10:47
@ziggie1984 ziggie1984 force-pushed the preparework-payments branch from dabf3ae to 467bd19 Compare July 15, 2025 11:13
@ziggie1984 ziggie1984 force-pushed the preparework-payments branch from 7f6637f to 488cb4d Compare July 15, 2025 12:45
@ziggie1984 ziggie1984 changed the title Refactor Payments Code (Head PR for refactor to make sure the itest pass) POC Payment SQL Support Jul 15, 2025
@saubyk saubyk removed this from lnd v0.20 Aug 5, 2025
@saubyk saubyk removed this from the v0.20.0 milestone Aug 5, 2025
@saubyk
Copy link
Collaborator

saubyk commented Aug 5, 2025

POC working as expected. Now the commits from this pr are being moved to other refactor prs. Closing this one.

@saubyk saubyk closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health Related to code commenting, refactoring, and other non-behaviour improvements payments Related to invoices/payments refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants