Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some documentation to help newcomers send Keysend payments #6360

Closed
wants to merge 3 commits into from

Conversation

brianoflondon
Copy link

@brianoflondon brianoflondon commented Mar 23, 2022

Change Description

It's documentation. It might nelp.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

docs/rest/keysend.md Outdated Show resolved Hide resolved
@lightninglabs-deploy
Copy link

@brianoflondon, remember to re-request review from reviewers when ready

@brianoflondon
Copy link
Author

@brianoflondon, remember to re-request review from reviewers when ready

I don't really have time to spend. This is a useful code example that would help newbies.

Publish or delete, lightning needs more and better documentation in my opinion but as you don't pay i have to spend more time on the project that does pay me.

Co-authored-by: Alex Bosworth <alexbosworth@users.noreply.github.com>
@guggero
Copy link
Collaborator

guggero commented Aug 3, 2022

Fair enough, thanks for the response and the initial contribution! We'll see if someone from the team has time to polish the text so we can merge it to our docs.

@guggero
Copy link
Collaborator

guggero commented Aug 4, 2022

Added to our builder's guide here: https://docs.lightning.engineering/lightning-network-tools/lnd/send-messages-with-keysend#docs-internal-guid-5736b677-7fff-7369-1bb3-cf686146b756
Thanks for the initial text, @brianoflondon.

@guggero guggero closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants