Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweep: add label to sweep transactions #5895

Merged

Conversation

bjarnemagnussen
Copy link
Contributor

Sweep transactions do currently not have the appropriate label set, which I think is an oversight as the LabelType for sweep transactions exists but is not in use for this case.

This PR adds the sweep label to sweep transactions.

@carlaKC carlaKC self-requested a review October 26, 2021 11:06
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was forgotten indeed. Thanks for the fix!
LGTM, just needs an entry in the release notes 🎉

Copy link
Collaborator

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@guggero guggero merged commit 6450f0c into lightningnetwork:master Oct 26, 2021
@Roasbeef Roasbeef added this to the v0.14.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants