Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor fixes to contribution guidelines #5503

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

Zero-1729
Copy link
Contributor

@Zero-1729 Zero-1729 commented Jul 11, 2021

This PR only fixes a minor typo and phrasing.

@Zero-1729 Zero-1729 changed the title docs: fixed minor typos docs: fixed minor typos in contribution guidelines Jul 11, 2021
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zero-1729 Zero-1729 changed the title docs: fixed minor typos in contribution guidelines docs: minor fixes to contribution guidelines Jul 19, 2021
@guggero
Copy link
Collaborator

guggero commented Jul 20, 2021

We added a new check that makes sure every PR has a short (one sentence) description in the release notes. If you rebase, you'll find a section Code health -> Code cleanup, refactor, typo fixes. Can you add the link to your PR there please?

@Zero-1729 Zero-1729 force-pushed the patch-2 branch 2 times, most recently from 8744c47 to 0079b60 Compare July 20, 2021 13:58
@Zero-1729
Copy link
Contributor Author

@guggero I also added bullet points to the contributors names, so it doesn't appear cluttered as it does in the v0.13.1 release notes. However, if you feel it unnecessarily breaks precedent, I'll be happy to revert the change to match the current v0.13.1 contributors listing format.

@guggero guggero disabled auto-merge July 20, 2021 15:39
@guggero guggero merged commit 480c17d into lightningnetwork:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants