Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample-lnd.conf: remove duplicate setting and clean up section separators #5448

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

xanoni
Copy link
Contributor

@xanoni xanoni commented Jun 29, 2021

973e87b remove extra whitespace and harmonizes the separators between config sections

2c92958 deletes a duplicate "nolisten=true" line + comment

@yyforyongyu
Copy link
Member

Thanks for the PR! The commit messages need to be modified a bit, similar to what you've done in this one.

@xanoni
Copy link
Contributor Author

xanoni commented Jun 30, 2021

Thanks for the PR! The commit messages need to be modified a bit, similar to what you've done in this one.

Hi! Do you mean the "doc/sample-lnd.conf: " prefix before the message? I think someone did that for me, because in my local repo I don't see it. Sure, I can add that.

However, I see the sample-lnd.conf in the repo root folder, not in a doc subfolder. I see a doc**s** folder, though. Should my commit move the file to "docs", or keep it in the root?

Harmonize formatting of section separators and clean up whitespace in
sample-lnd.conf
Remove duplicate `nolisten` setting in sample-lnd.conf
@xanoni
Copy link
Contributor Author

xanoni commented Jun 30, 2021

@yyforyongyu I created 2 versions of this PR. In this version here I don't move the file to docs. In #5451 I do move the file. Pick one of the 2 :)

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I prefer this version over #5451. Makes it easier for people to find the example config.

Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍
Like @guggero mentioned I think this version is better. Thanks for the PRs!

@Roasbeef Roasbeef added this to the v0.14.0 milestone Jul 9, 2021
@Roasbeef Roasbeef merged commit 7e4b2b8 into lightningnetwork:master Jul 9, 2021
@xanoni xanoni deleted the sample-lnd-conf-cleanup branch July 10, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants