RPC/CLI: Allow abandonchannel to be used in regular build #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An often requested feature is to use the abandonchannel API in regular builds and not only dev builds to get rid of stuck channels that had their funding transaction invalidated. The initial reason for putting the call behind the build flag was a safety concern to make sure nobody uses this on active channels by accident.
guggero
force-pushed
the
abandonchannel-no-dev
branch
from
ff04469
to
3b712bf
Compare
This was referenced Jun 3, 2021
Closed
wpaulino
approved these changes
Jun 22, 2021
carlaKC
approved these changes
Jun 23, 2021
I agree, this is already being tracked in #386. This serves as a temporary solution until that is implemented, and we should probably revert this change after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An often requested feature is to use the abandonchannel API in regular
builds and not only dev builds to get rid of stuck channels that had
their funding transaction invalidated.
The initial reason for putting the call behind the build flag was a
safety concern to make sure nobody uses this on active channels by
accident.