scripts/keys: update roasbeef keys with new expiry#10313
scripts/keys: update roasbeef keys with new expiry#10313Roasbeef merged 1 commit intolightningnetwork:masterfrom
Conversation
My key recently expired, in this commit, we update the keys to the new refreshed version. These are the same keys, but with an expiry further out. Here's a clear sign of the latest Bitcoin block hash: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 000000000000000000013215ef7c32bc0427f388fc83623affe712f388 -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQpYhJoGq3wVlaize6QUl997uCthgUCaPi6xwAKCRCQUl997uCt hpqNAQC5VnnbO6h/PjywGhU4LLRvH8SdgdDEMSc7xrtWd1vgPgD+IDrHqiAb+h38 ORBnUVJCVuZrPebtdnYXVQhII91eaw4= =WRbl -----END PGP SIGNATURE-----
Summary of ChangesHello @Roasbeef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the integrity and usability of cryptographic assets by updating an expired PGP public key. The change ensures that the key associated with 'roasbeef' remains valid for verification purposes, preventing disruptions due to key expiration by extending its validity period. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the PGP key for roasbeef with a new expiry date. I have reviewed the changes and identified one critical issue related to the validity of the updated key. Specifically, the script scripts/check-pgp-expiry.sh checks for key expiry, and if the key is invalid, it will cause issues.
| uvIdihEDAQgHiH4EGBYKACYCGwwWIQSlthiWlS2f2oO8BUzcQmEuiSNxggUCaPi5 | ||
| 3AUJA8xHIQAKCRDcQmEuiSNxgkmLAPwLEHJ6D6nciPL0ot2FX8Or3l0nJQnuABQ1 | ||
| z4iuss0C9QEA4Zn6765uDnbnKFvVykRWzdhQbbJZfZ9SZxrHuA2KAgm4MwRnFuEg | ||
| FgkrBgEEAdpHDwEBB0DzxAfJDJBe4cnOMkUt22iHY6jNTPFAetZy23qOAiHvcYh+ | ||
| BBgWCgAmFiEEpbYYlpUtn9qDvAVM3EJhLokjcYIFAmcW4SACGyAFCQHhM4AACgkQ | ||
| 3EJhLokjcYKAjwEAsnsoIyF/2xptEMIwziuRTv5sJmbWJejxggiPxO8x3D4BAMk2 | ||
| CKC48FNbNI4UVNCROVQx4/eJPamZ+LzK4MPeikcOuDMEZxbhdhYJKwYBBAHaRw8B | ||
| AQdAE2ATLfAU8F6jeYEHSHgNimYhr2zuqrxASPVx/Q2xWV+I9QQYFgoAJhYhBKW2 | ||
| GJaVLZ/ag7wFTNxCYS6JI3GCBQJnFuF2AhsCBQkB4TOAAIEJENxCYS6JI3GCdiAE | ||
| GRYKAB0WIQQpYhJoGq3wVlaize6QUl997uCthgUCZxbhdgAKCRCQUl997uCthtbg | ||
| APsFK5LRqt78/cscdRIuPMAqdZmXNr2XDtWjUZ8WQf72XwEAm8/BCodJvfiMWMyD | ||
| Urc7HOdLqnFrRWkj1OQineUpHAsHawEAhAwn/eoJ42KcXsCiuxgpEvL996VHHiOf | ||
| I2iWx2w9AEQBAKmpEwfQDz6k4/913HGkki1seOS1LJq+3+kGJsu/V74H | ||
| =6iqc | ||
| BBgWCgAmAhsgFiEEpbYYlpUtn9qDvAVM3EJhLokjcYIFAmj4uckFCQPMRqYACgkQ | ||
| 3EJhLokjcYLI9QEApSUNUe8WxU2KCs+IpvT7wGLguplbjPDQFOhsR5y2ORkA/A8G | ||
| 7Zl5tu7z3gKmAxB82HJ8S+X7wlrn86dI4s3mfxUCuDMEZxbhdhYJKwYBBAHaRw8B | ||
| AQdAE2ATLfAU8F6jeYEHSHgNimYhr2zuqrxASPVx/Q2xWV+I9QQYFgoAJgIbAhYh | ||
| BKW2GJaVLZ/ag7wFTNxCYS6JI3GCBQJo+LnlBQkDzEZtAIF2IAQZFgoAHRYhBCli |
There was a problem hiding this comment.
Soft verified that the provided PGP signed message indeed matches the new pubkey:
❯ gpg --import roasbeef.asc 15:49:14
gpg: key DC42612E89237182: public key "Olaoluwa Osuntokun <laolu32@gmail.com>" imported
gpg: Total number processed: 1
gpg: imported: 1
~
❯ gpg --verify msg.asc 15:50:17
gpg: Signature made Sze Okt 22 13:06:47 2025 CEST
gpg: using EDDSA key 296212681AADF05656A2CDEE90525F7DEEE0AD86
gpg: Good signature from "Olaoluwa Osuntokun <laolu32@gmail.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: A5B6 1896 952D 9FDA 83BC 054C DC42 612E 8923 7182
Subkey fingerprint: 2962 1268 1AAD F056 56A2 CDEE 9052 5F7D EEE0 AD86
LGTM 🎉
My key recently expired, in this commit, we update the keys to the new refreshed version. These are the same keys, but with an expiry further out.
Here's a clear sign of the latest Bitcoin block hash: