Skip to content

update Golang version to v1.23.12 to fix potential SQL bug#10139

Merged
guggero merged 2 commits intolightningnetwork:masterfrom
ziggie1984:update-golang-version
Aug 8, 2025
Merged

update Golang version to v1.23.12 to fix potential SQL bug#10139
guggero merged 2 commits intolightningnetwork:masterfrom
ziggie1984:update-golang-version

Conversation

@ziggie1984
Copy link
Collaborator

  • multi: bump Golang version to v1.23.12
  • docs: add release notes

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the project's Go version to 1.23.12. This change is crucial for addressing a potential SQL bug and ensures that our development and deployment environments are aligned with the latest stable Go release. The update involved modifying various configuration files, Docker images, and documentation to reflect the new Go version across the codebase.

Highlights

  • Go Version Update: The primary change in this pull request is the update of the Go programming language version from 1.23.10 to 1.23.12. This update is specifically intended to address and fix a potential SQL bug.
  • Configuration Updates: To ensure consistency across the project, I've updated various configuration files, including .golangci.yml, Makefile, and the go.mod files within several modules (e.g., healthcheck, kvdb, sqldb, tlv, tools, tor), to reflect the new Go version.
  • Dockerfile Updates: All relevant Dockerfiles (Dockerfile, dev.Dockerfile, docker/btcd/Dockerfile, lnrpc/Dockerfile, make/builder.Dockerfile, tools/Dockerfile) and the lnrpc/gen_protos_docker.sh script have been updated to utilize the golang:1.23.12 base image, ensuring that all containerized environments and build processes use the latest Go version.
  • Documentation Update: The docs/INSTALL.md file has been updated to reflect the new minimum Go version (1.23.12) and includes the corresponding wget commands and SHA256 sums for installation. Additionally, the release notes (docs/release-notes/release-notes-0.19.3.md) have been updated to explicitly mention this Go version bump under the 'Code Health' section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version from 1.23.10 to 1.23.12 across the entire project, including build scripts, Dockerfiles, CI configurations, and module files. Release notes have also been added to reflect this change.

While the version bump is applied consistently, I've found a critical issue in the installation documentation (docs/INSTALL.md). The SHA256 checksums for the new Go version have not been updated for the linux-amd64 and linux-armv6l distributions. This will cause the verification step to fail for users and poses a security risk. Please update the checksums to their correct values.

@ziggie1984 ziggie1984 force-pushed the update-golang-version branch from 6aa8f7b to ab6f1fc Compare August 7, 2025 14:54
@ziggie1984
Copy link
Collaborator Author

@gemini-code-assist review

@ziggie1984 ziggie1984 requested review from bhandras and guggero August 7, 2025 14:55
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version from 1.23.10 to 1.23.12 across the entire project. The changes are consistent and correctly applied to all relevant configuration files, Dockerfiles, build scripts, and documentation. I've included one minor suggestion regarding line length in the release notes to adhere to the project's style guide.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🎉

@guggero guggero merged commit e00a072 into lightningnetwork:master Aug 8, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants