update Golang version to v1.23.12 to fix potential SQL bug#10139
update Golang version to v1.23.12 to fix potential SQL bug#10139guggero merged 2 commits intolightningnetwork:masterfrom
Conversation
ziggie1984
commented
Aug 7, 2025
- multi: bump Golang version to v1.23.12
- docs: add release notes
There was a problem hiding this comment.
Summary of Changes
Hello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the project's Go version to 1.23.12. This change is crucial for addressing a potential SQL bug and ensures that our development and deployment environments are aligned with the latest stable Go release. The update involved modifying various configuration files, Docker images, and documentation to reflect the new Go version across the codebase.
Highlights
- Go Version Update: The primary change in this pull request is the update of the Go programming language version from
1.23.10to1.23.12. This update is specifically intended to address and fix a potential SQL bug. - Configuration Updates: To ensure consistency across the project, I've updated various configuration files, including
.golangci.yml,Makefile, and thego.modfiles within several modules (e.g.,healthcheck,kvdb,sqldb,tlv,tools,tor), to reflect the new Go version. - Dockerfile Updates: All relevant Dockerfiles (
Dockerfile,dev.Dockerfile,docker/btcd/Dockerfile,lnrpc/Dockerfile,make/builder.Dockerfile,tools/Dockerfile) and thelnrpc/gen_protos_docker.shscript have been updated to utilize thegolang:1.23.12base image, ensuring that all containerized environments and build processes use the latest Go version. - Documentation Update: The
docs/INSTALL.mdfile has been updated to reflect the new minimum Go version (1.23.12) and includes the correspondingwgetcommands and SHA256 sums for installation. Additionally, the release notes (docs/release-notes/release-notes-0.19.3.md) have been updated to explicitly mention this Go version bump under the 'Code Health' section.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.23.10 to 1.23.12 across the entire project, including build scripts, Dockerfiles, CI configurations, and module files. Release notes have also been added to reflect this change.
While the version bump is applied consistently, I've found a critical issue in the installation documentation (docs/INSTALL.md). The SHA256 checksums for the new Go version have not been updated for the linux-amd64 and linux-armv6l distributions. This will cause the verification step to fail for users and poses a security risk. Please update the checksums to their correct values.
6aa8f7b to
ab6f1fc
Compare
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.23.10 to 1.23.12 across the entire project. The changes are consistent and correctly applied to all relevant configuration files, Dockerfiles, build scripts, and documentation. I've included one minor suggestion regarding line length in the release notes to adhere to the project's style guide.