Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainrg: lnd uses wrong coin type for simnet and other networks #6952

Open
Roasbeef opened this issue Sep 28, 2022 · 0 comments
Open

chainrg: lnd uses wrong coin type for simnet and other networks #6952

Roasbeef opened this issue Sep 28, 2022 · 0 comments
Labels
bug Unintended code behaviour config Parameters/arguments/config file related issues/PRs wallet The wallet (lnwallet) which LND uses

Comments

@Roasbeef
Copy link
Member

Today lnd uses the wrong coin type for simnet and other networks: https://github.com/lightningnetwork/lnd/blob/master/chainreg/chainparams.go#L45-L58

We'll bail out of certain operations like PSBT signing if the coin type doesn't match what we expect. The cointype for testnet is 1, while the actual cointype for simnet is 115: https://github.com/btcsuite/btcd/blob/master/chaincfg/params.go#L758-L760

I think this was just a historical simplification, but we should likely update to start using th correct coin types, as I think maybe the "default" signet has a diff value. Alternatively, we can just mark this as wontfix as well.

@Roasbeef Roasbeef added bug Unintended code behaviour wallet The wallet (lnwallet) which LND uses config Parameters/arguments/config file related issues/PRs labels Sep 28, 2022
Roasbeef added a commit to lightninglabs/taproot-assets that referenced this issue Sep 28, 2022
Roasbeef added a commit to lightninglabs/taproot-assets that referenced this issue Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended code behaviour config Parameters/arguments/config file related issues/PRs wallet The wallet (lnwallet) which LND uses
Projects
None yet
Development

No branches or pull requests

1 participant