GitHub: use maintained version of docker layer cache action #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstadulis
reviewed
Aug 28, 2023
There was a problem hiding this comment.
FWIW, jpribyl/action-docker-layer-caching has some sort of CI failure itself. Might be inconsequential: https://github.com/jpribyl/action-docker-layer-caching/actions?query=workflow%3A%22Readme+Test%22
| @@ -42,7 +42,8 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| - name: docker image cache | |||
| uses: satackey/action-docker-layer-caching@v0.0.11 | |||
| uses: jpribyl/action-docker-layer-caching@v0.1.1 | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
After some reading about this workflow, I saw this comment. Adding a link in case it's relevant for reviewer to assess soundness
|
We just use this caching step to make sure we don't hit the Docker Hub pull limit. We don't actually care that much if it fails from time to time, as long as it does its job most of the time. |
positiveblue
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the old
satackey/action-docker-layer-cachingaction has finally stopped working: https://github.com/lightninglabs/taproot-assets/actions/runs/5999726192/job/16270427354We update to a forked version that is maintained and also allow the test to continue if the caching fails.