blockmanager.go: use btcd libs to validate headers #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was performed for both the reorg and non-reorg cases, but in the reorg case the headers would count for PoW before validating that the headers connected to one another.
This uses btcd's HeaderCtx and ChainCtx interfaces to be able to validate headers, both contextually and context-free. This allows neutrino to call blockchain.CheckBlockHeaderContext and blockchain.CheckBlockHeaderSanity.
Crypt-iQ
force-pushed
the
context_header
branch
from
febc308
to
ddb3f6a
Compare
Roasbeef
reviewed
May 23, 2023
| @@ -2383,6 +2383,33 @@ func (b *blockManager) handleHeadersMsg(hmsg *headersMsg) { | |||
| // atomically in order to improve peformance. | |||
| headerWriteBatch := make([]headerfs.BlockHeader, 0, len(msg.Headers)) | |||
|
|
|||
| // Explicitly check that each header in msg.Headers builds off of the | |||
There was a problem hiding this comment.
Can be moved out into a some helper function. Also would have though the functions we exported from btcd would handle it so we don't need to do it again?
| err := b.checkHeaderSanity(blockHeader, maxTimestamp, | ||
| false) | ||
| false, prevNodeHeight, &prevNodeHeader) |
|
|
||
| var prevNodeHeader *wire.BlockHeader | ||
|
|
||
| if i+j == 0 { |
| } | ||
| return nil | ||
|
|
||
| err = blockchain.CheckBlockHeaderSanity( |
|
Can be rebased now! |
|
Replaced by #283, addressed all open review comments there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses btcd's HeaderCtx and ChainCtx interfaces to be able to validate headers, both contextually and context-free. This allows neutrino to call blockchain.CheckBlockHeaderContext and blockchain.CheckBlockHeaderSanity. Also included is a check to assert that when neutrino receives a p2p headers message, that each header connects to the previous one.
TODO: