Add LiT CI job and runner cleanup action #1050
Conversation
Summary of ChangesHello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration pipeline by introducing a mechanism to manage runner disk space and integrating a new testing suite. The disk cleanup action ensures that CI jobs, especially those with high disk requirements, have sufficient resources, while the LiT job expands the test coverage for integration and unit tests. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new composite GitHub Action, cleanup-space, designed to free up disk space on runners. This is a useful addition for resource-intensive CI jobs. The implementation is a good start, but I've identified a couple of areas for improvement in the shell script to ensure it behaves correctly and is easier to debug. My main concerns are around shell globbing behavior and error visibility. Please see my detailed comments.
ffranr
force-pushed
the
add-ci-lit-test
branch
5 times, most recently
from
bb81e5a to
a60153b
Compare
ffranr
force-pushed
the
add-ci-lit-test
branch
from
af044eb to
81c0874
Compare
starius
left a comment
starius
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Added a couple of nits.
| path: | | ||
| ~/.cache/yarn | ||
| lightning-terminal/app/node_modules | ||
| key: ${{ runner.os }}-lit-node16-${{ hashFiles('lightning-terminal/app/yarn.lock') }} |
There was a problem hiding this comment.
Is it time to bump LiT to latest node LTS version? (24)
There was a problem hiding this comment.
This is the action we basically have in taproot-assets right now. I think there's some value in that consistency. I'll try to upgrade both soon. Thanks for the heads up on this.
ffranr
force-pushed
the
add-ci-lit-test
branch
from
81c0874 to
104b50d
Compare
Add a new workflow to run tests for the LiT repository. This includes setting up dependencies, cloning the repository, and updating the `go.mod` file to use local Loop modules.
ffranr
force-pushed
the
add-ci-lit-test
branch
from
104b50d to
d56fb5b
Compare
3 participants
Pull Request Checklist
Updaterelease_notes.mdif your PR contains major features, breaking changes or bugfixes