Skip to content

collectors: distinguish attempts by payment status #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

calvinrzachman
Copy link
Contributor

@calvinrzachman calvinrzachman commented May 5, 2025

Add a label to the metric for tracking htlc attempts so that we can differentiate between attempts made as part of payments that are successful from attempts for payments which fail.

This allows you to answer questions like: How many attempts does a successful payment take on average?

The exported metrics would look like:

# HELP lnd_total_htlc_attempts Total number of HTLC attempts across all payments
# TYPE lnd_total_htlc_attempts counter
lnd_total_htlc_attempts{status="failed"} 10
lnd_total_htlc_attempts{status="succeeded"} 5

# HELP lnd_total_payments Total number of payments initiated, labeled by final status
# TYPE lnd_total_payments counter
lnd_total_payments{status="failed"} 1
lnd_total_payments{status="succeeded"} 5

Extends: #115

Add a label to the metric for tracking htlc attempts so
that we can differentiate between attempts made as part
of payments that are successfull from attempts for payments
which fail.

This allows you to answer questions like: How many attempts
does a successful payment take on average?
Copy link
Contributor

@djkazic djkazic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice upgrade!

Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM ⚡

@guggero guggero merged commit a50893d into lightninglabs:master May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants