multi: modularise subserver handling #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the code for creating remote connections to loop, faraday and pool subservers from the rpcProxy. This is now handled by the subserver manager.
positiveblue
approved these changes
May 3, 2023
There was a problem hiding this comment.
These changes make it so much cleaner. Thank you @ellemouton
Note: i did not test the integrate/remote combination that panic in #537
Ensure that all of Lit's subserver loggers have been registered _before_ the config is validated. This will allow users to use the `--lnd.debuglevel` flag to set Lit specific subserever logger levels.
|
Thanks @positiveblue!
No worries - that panic is only (it seems) related to the situation where one sub-server is disabled. Which is not the case here. |
Due to the rpcProxy being started early now, it could be the case that a call is made to `GetRemoteConn` before the remote connection has actually been set up. This commit catches this case so that an error can be returned and a panic avoided.
|
note: i have added one more commit on the end which I think will fix the panic that was noted by Jamal 🤞 |
In the rpcProxy `makeDirector` method, we need to check if the rpcProxy has started before making use of the `lndConn`.
|
one more commit with the same nature |
guggero
approved these changes
May 3, 2023
| faradayPerms string = "faraday" | ||
| litPerms string = "lit" | ||
| lndPerms string = "lnd" | ||
| litPerms string = "lit" |
There was a problem hiding this comment.
Nice! A little bit less duplication 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first couple of commits of #537 without the disabling logic.