doublespendinputs: allow RBF per default #118
Conversation
Tetrix42
force-pushed
the
doublespend_rbf
branch
from
8f6acf4 to
3b50a5c
Compare
| for _, outpoint := range outpoints { | ||
| tx.AddTxIn(wire.NewTxIn(outpoint, nil, nil)) | ||
|
|
||
| tx.AddTxIn(&wire.TxIn{ |
There was a problem hiding this comment.
The AddTxIn already uses wire.MaxTxInSequenceNum under the hood. So I don't think any change is required? I don't think it makes sense to be able to turn off RBF?
There was a problem hiding this comment.
the default it usse is indeed
// MaxTxInSequenceNum is the maximum sequence number the sequence field
// of a transaction input can be.
MaxTxInSequenceNum uint32 = 0xffffffff
but this value disallows RBF.
therefore to allow RBF this PR changes the default to
// MaxRBFSequence is the maximum sequence number an input can use to
// signal that the transaction spending it can be replaced using the
// Replace-By-Fee (RBF) policy.
MaxRBFSequence = 0xfffffffd
and introduces a switch to give the users the possibility to make a final transactions.
There was a problem hiding this comment.
Ah, you're right. I got the two values confused. So I guess we'll just want RBF to be the default, no need to turn it off. Removes the need for the boolean flag which has bad UX if the default is true.
There was a problem hiding this comment.
Ok so i pushed new commit without the rbf flag.
Tetrix42
force-pushed
the
doublespend_rbf
branch
from
fae020c to
d9af0e3
Compare
doublespendinputsis designed to replace transactions, those new transactions should also be replacable by default.