-
Notifications
You must be signed in to change notification settings - Fork 21
Update Cargo.lock, pin time dependecy
#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
rust/Cargo.lock
Outdated
| [[package]] | ||
| name = "time" | ||
| version = "0.3.44" | ||
| version = "0.3.36" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MSRV bump happened in 0.3.46 so let's set this to 0.3.45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Thanks for the PR ! Do I understand correctly, on the current main branch,
Because you want CI to enforce that builds pass for the exact |
The newer `time` version requires Rust 1.88
7891c27 to
7451b0d
Compare
With this change it works locally and in docker.
Correct. |
tankyleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrei-21 can you run cargo update again ? When I run this command on top of your branch, I get a pretty big update to the Cargo.lock. Then as before we pin the time dependency.
tankyleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fix the typo in the commit message thank you :)
The newer
timeversion requires Rust 1.88