Skip to content

Set MSRV to 1.85.0 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnull merged 1 commit into from
Jan 23, 2026
Merged

Set MSRV to 1.85.0 #85

tnull merged 1 commit into from
Jan 23, 2026

Conversation

@tankyleo
Copy link
Contributor

@tankyleo tankyleo commented Jan 20, 2026

Fixes #63

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 20, 2026 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from tnull January 20, 2026 17:42
tnull
tnull reviewed Jan 20, 2026
View reviewed changes
rust/README.md
[LDK Discord]: https://discord.gg/5AcknnMfBw

### MSRV
The Minimum Supported Rust Version (MSRV) is currently 1.85.0.
Copy link
Contributor

@tnull tnull Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but given that what is untested is broken, let's add a CI job that also builds and runs tests on MSRV? Also we'll want to set rust-version in Cargo.toml.

Copy link
Contributor Author

@tankyleo tankyleo Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminders yes.

@tankyleo tankyleo force-pushed the 26-01-add-msrv branch 4 times, most recently from c28fa59 to 73e8165 Compare January 23, 2026 00:31
@tankyleo
Set MSRV to 1.85.0
af4e46c 
Also add the "Implementation Tests" workflow to CI
@tankyleo tankyleo requested a review from tnull January 23, 2026 00:45
@tankyleo
Copy link
Contributor Author

tankyleo commented Jan 23, 2026

Thanks for taking a look Elias I also add CI for the postgres backend tests in rust/impls

tnull
tnull approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tnull tnull merged commit fec89fb into lightningdevkit:main Jan 23, 2026
6 checks passed
@tankyleo tankyleo deleted the 26-01-add-msrv branch January 26, 2026 19:49
@tankyleo tankyleo self-assigned this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull approved these changes

Assignees

@tankyleo tankyleo

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an MSRV policy

3 participants

@tankyleo @ldk-reviews-bot @tnull