Correct post-update action comment on claims from closed chans#3985
Conversation
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-`ChannelMonitorUpdate` completion action immediately as we didn't actually track async `ChannelMonitorUpdate`s to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated. Thus, here we update the comment, for the easiest close on a major feature issue ever. Fixes lightningdevkit#2355.
|
I've assigned @valentinewallace as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.02%
==========================================
Files 174 174
Lines 124201 124201
Branches 124201 124201
==========================================
- Hits 110472 110459 -13
- Misses 11251 11261 +10
- Partials 2478 2481 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @valentinewallace! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
3 participants
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-
ChannelMonitorUpdatecompletion action immediately as we didn't actually track asyncChannelMonitorUpdates to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated.Thus, here we update the comment, for the easiest close on a major feature issue ever.
Fixes #2355.