Skip to content

Update channel_reestablish for splicing #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Update channel_reestablish for splicing #3886

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bd294b3
Add features for splicing
jkczyz Jun 19, 2025
99affd3
Add funding_locked_txid TLVs to channel_reestablish
jkczyz Jun 5, 2025
fa4c9c9
Set funding_locked_txid TLVs in channel_reestablish
jkczyz Jun 8, 2025
2c790d0
f - don't check splice feature bit
jkczyz Jul 11, 2025
5789c8f
Update channel_reestablish logic for channel_ready
jkczyz Jun 19, 2025
ab5ccd1
Enter FundingNegotiated state after constructing funding tx
jkczyz Jul 9, 2025
cb31e89
Return an Option from ChannelContext::get_initial_commitment_signed
jkczyz Jul 9, 2025
cc4152f
f - TODO(splicing): Support async signing
jkczyz Jul 11, 2025
4a0e343
Update next_funding_txid logic for channel_reestablish
jkczyz Jun 23, 2025
5123cc8
f - clean up spec requirement
jkczyz Jul 11, 2025
5619b37
Use consistent initial commitment_signed naming
jkczyz Jul 11, 2025
feffea4
Update next_commitment_number logic for channel_reestablish
jkczyz Jun 23, 2025
1047dcd
f - add comment with spec requirement
jkczyz Jul 11, 2025
71ffb50
Send splice_locked on channel_reestablish
jkczyz Jun 20, 2025
b647280
Retransmit channel_ready / splice_locked awaiting announcement_sigs
jkczyz Jun 25, 2025
a907398
Clear announcement_sigs on FundingScope promotion
jkczyz Jun 25, 2025
15eef7b
Send channel_ready on channel_reestablish
jkczyz Jun 27, 2025
8004c6f
Handle implicit splice_locked during channel_reestablish
jkczyz Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
f - TODO(splicing): Support async signing
  • Loading branch information
@jkczyz
jkczyz committed Jul 11, 2025
commit cc4152f0b2f58df114b91e2cedebda34e21c7cb8
5 changes: 3 additions & 2 deletions lightning/src/ln/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2966,6 +2966,7 @@ where
let commitment_signed = self.context.get_initial_commitment_signed(&self.funding, logger);
let commitment_signed = match commitment_signed {
Some(commitment_signed) => commitment_signed,
// TODO(splicing): Support async signing
None => {
self.funding.channel_transaction_parameters.funding_outpoint = None;
return Err(ChannelError::Close(
Expand Down Expand Up @@ -5544,7 +5545,7 @@ where
partial_signature_with_nonce: None,
})
} else {
// TODO: Support async signing
// TODO(splicing): Support async signing
None
}
}
Expand Down Expand Up @@ -8425,7 +8426,7 @@ where
// if next_commitment_number is zero:
// MUST retransmit its commitment_signed for that funding transaction.
let commitment_signed = self.context.get_initial_commitment_signed(&self.funding, logger)
// TODO Support async signing
// TODO(splicing): Support async signing
.ok_or_else(|| ChannelError::Close(
(
"Failed to get signatures for new commitment_signed".to_owned(),
Expand Down