Allow counterparty pending monitor update within quiescence handshake #3806
Conversation
Previously, if we were negotiating quiescence, and we had already sent our `stfu`, we'd disconnect upon receiving the counterparty's `stfu` if we had a pending monitor update. This could result from processing a counterparty's final `revoke_and_ack` to an update, and immediately processing their `stfu` (which is valid from their point of view) without complete the monitor update. This was unintended, as we are able to track the quiescent and pending monitor update flags at the same time. Note that this commit still considers whether our signer owes any messages, as these are indicative of a channel update still pending.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
- Coverage 89.75% 89.73% -0.03%
==========================================
Files 159 159
Lines 128828 128878 +50
Branches 128828 128878 +50
==========================================
+ Hits 115634 115653 +19
- Misses 10511 10537 +26
- Partials 2683 2688 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
🔔 1st Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
There was a problem hiding this comment.
Confirmed this also fixes the issue for seed
export HEX="06000000001b000000000000020000000000000000200000be0000000000
000000000000ff0e0000a3a3a3a3a3a3a3a3a30015ffffffffffefff0000
000000ff"
which we just hit once more in #3804.
Previously, if we were negotiating quiescence, and we had already sent our
stfu, we'd disconnect upon receiving the counterparty'sstfuif we had a pending monitor update. This could result from processing a counterparty's finalrevoke_and_ackto an update, and immediately processing theirstfu(which is valid from their point of view) without complete the monitor update. This was unintended, as we are able to track the quiescent and pending monitor update flags at the same time. Note that this commit still considers whether our signer owes any messages, as these are indicative of a channel update still pending.Fixes #3805.