Replace rustfmt_excluded_files with rustfmt_skip cfg attribute #3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
lightning/src/ln/update_fee_tests.rs
Outdated
| @@ -526,6 +541,14 @@ pub fn test_update_fee_that_funder_cannot_afford() { | |||
| check_closed_event!(nodes[1], 1, reason, [node_a_id], channel_value); | |||
| } | |||
|
|
|||
| #[xtest(feature = "_externalize_tests")] | |||
There was a problem hiding this comment.
Are the update_fee_test and channel.rs changes intentional? It seems like they could use their own commit if so
There was a problem hiding this comment.
I have really no idea how that slipped through. Reverted.
joostjager
force-pushed
the
rustfmt-skip
branch
3 times, most recently
from
1176fc2 to
e7af289
Compare
valentinewallace
previously approved these changes
May 27, 2025
|
Requested @tnull's review since @TheBlueMatt is off review this week, so hopefully we can land. |
tnull
reviewed
May 28, 2025
This change removes the custom `rustfmt_excluded_files` mechanism and instead uses the an attribute at the top of each excluded file. No functional changes are introduced. This simplifies formatting workflows by enabling standard `cargo fmt` and editor format-on-save features without custom scripts. The older `rustfmt` cfg attribute is used because newer formatting directives only support code blocks, which would require more effort to apply consistently. This commit focuses on improving developer experience by streamlining formatting setup, while more granular or comprehensive formatting can be addressed later.
tnull
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the custom
rustfmt_excluded_filesmechanism and instead uses an attribute at the top of each excluded file.No functional changes are introduced. This simplifies formatting workflows by enabling standard
cargo fmtand editor format-on-save features without custom scripts.The older
rustfmtcfg attribute is used because newer formatting directives only support code blocks, which would require more effort to apply consistently. This commit focuses on improving developer experience by streamlining formatting setup, while more granular or comprehensive formatting can be addressed later.