-
Notifications
You must be signed in to change notification settings - Fork 410
Exchange splice_locked
messages
#3741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkczyz
wants to merge
23
commits into
lightningdevkit:main
Choose a base branch
from
jkczyz:2025-04-splice-locked
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+834
−259
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2f6c2fb
Generalize do_chain_event signature for splicing
jkczyz cee02cc
Move ChannelContext::funding_tx_confirmed_in to FundingScope
jkczyz 3969264
Move ChannelContext::funding_tx_confirmation_height to FundingScope
jkczyz fc88b9f
Move ChannelContext::short_channel_id to FundingScope
jkczyz dd0164a
Refactor funding tx confirmation check into helper
jkczyz 80c8f6e
Check FundingScope::funding_transaction for coinbase tx
jkczyz b238d2d
Add FundingScope::get_funding_txid helper
jkczyz 331b869
Reset FundingScope::funding_tx_confirmation_height
jkczyz d39141f
Special case 0-conf in check_funding_meets_minimum_depth
jkczyz a6eb6d1
Check confirmation of pending funding transactions
jkczyz a2cdf9c
f - add logging to maybe_promote_splice_funding
jkczyz 5d72742
f - update minimum_depth docs
jkczyz d0c9491
Move check_funding_meets_minimum_depth to FundedChannel
jkczyz 6de3864
Account for coinbase tx in ChannelContext::minimum_depth
jkczyz 4eda555
Check unconfirmation of pending funding transactions
jkczyz 9f16c0a
f - fix CI
jkczyz f734bff
f - add logging to transaction_unconfirmed
jkczyz 3ae66bf
Check all FundingScopes in get_relevant_txids
jkczyz eed13e8
Handle splice_locked message
jkczyz a473983
f - add logging to splice_locked
jkczyz 1811e72
Track historical SCIDs from previous funding
jkczyz 4f5af9f
Emit SpliceLocked event
jkczyz bff123e
Add funding_txo to ChannelReady event
jkczyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.