Allow ElectrumSyncClient to reuse a preexisting client
#3646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our API would only allow users to have `ElectrumSyncClient` a) construct an entirely `new` `electrum_client::Client` or b) take an owened client via `from_client`. Here, we change `ElectrumSyncClient::from_client` to accept an `Arc<ElectrumClient>`, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.
|
I've assigned @arik-so as a reviewer! |
TheBlueMatt
approved these changes
Mar 5, 2025
wpaulino
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our API would only allow users to have
ElectrumSyncClienta) construct an entirelynewelectrum_client::Clientor b) take an owened client viafrom_client.Here, we change
ElectrumSyncClient::from_clientto accept anArc<ElectrumClient>, allowing to reuse a pre-existing client without owning it. This is important as it will allow us to reuse the same connection instead of forcing users to establish multiple connections if they need something beyond syncing LDK.