Allow uppercase bech32 HRP (main)#3506
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Jan 8, 2025
Merged
Conversation
tnull
force-pushed
the
2025-01-allow-upperase-hrp-main
branch
5 times, most recently
from
af8c035 to
92f5d16
Compare
Previously, we would fail parsing `Offer`s if the HRP didn't match our expected (lowercase) HRP. Here, we relax this check in accordance with the spec to also allow all-uppercase HRPs.
.. to ensure we're able to decode all-uppercase HRPs and reject mixed-case encodings.
tnull
force-pushed
the
2025-01-allow-upperase-hrp-main
branch
from
92f5d16 to
7d653c2
Compare
arik-so
approved these changes
Jan 8, 2025
Contributor
Author
|
Going ahead and landing this with one ACK as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #3505, but against
mainso we don't only have the change in the 0.1 branch.Previously, we would fail parsing
Offers if the HRP didn't match our expected (lowercase) HRP. Here, we relax this check in accordance with the spec to also allow all-uppercase HRPs.