Skip to content

docs/trivial: update diagram to reflect changes to KeysInterface #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carlaKC
Copy link
Contributor

@carlaKC carlaKC commented Oct 8, 2024

KeysInterface was split into EntropySource, SignerProvider and NodeSigner in #1930, update diagram to match.

KeysInterface was split into EntropySource, SignerProvider and
NodeSigner in lightningdevkit#1930.
@carlaKC carlaKC force-pushed the arch-update-keys-interface branch from 4961ab5 to 7c1db56 Compare October 8, 2024 14:35
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (bc1931b) to head (7c1db56).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
- Coverage   89.62%   89.59%   -0.04%     
==========================================
  Files         127      127              
  Lines      103517   103517              
  Branches   103517   103517              
==========================================
- Hits        92780    92745      -35     
- Misses       8041     8071      +30     
- Partials     2696     2701       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit e4ec917 into lightningdevkit:main Oct 8, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants