Disambiguate blinded path ForwardNodes between payment + message
#3265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 89.82% 89.79% -0.03%
==========================================
Files 125 125
Lines 102867 102867
Branches 102867 102867
==========================================
- Hits 92398 92370 -28
- Misses 7753 7779 +26
- Partials 2716 2718 +2 ☔ View full report in Codecov by Sentry. |
|
Looks like fuzz code needs to be updated. |
TheBlueMatt
force-pushed
the
2024-08-globally-unique-names
branch
from
fd8fc08 to
9ab9eca
Compare
|
Fixed. |
TheBlueMatt
force-pushed
the
2024-08-globally-unique-names
branch
from
9ab9eca to
2c69fbd
Compare
We currently have two structs with identical names in our public API - `blinded_path::message::ForwardNode` and `blinded_path::payment::ForwardNode`. This makes the API somewhat awkward to use - users have to try (and fail) to import `ForwardNode` twice only to then have to change their imports. More importantly, however, this makes the API very hard to use in some bindings languages where rename-imports or module imports aren't available. Thus, here, we rename both to give them context.
TheBlueMatt
force-pushed
the
2024-08-globally-unique-names
branch
from
2c69fbd to
2ce2fe9
Compare
jkczyz
approved these changes
Aug 21, 2024
valentinewallace
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have two structs with identical names in our public API -
blinded_path::message::ForwardNodeandblinded_path::payment::ForwardNode. This makes the API somewhat awkward to use - users have to try (and fail) to importForwardNodetwice only to then have to change their imports.More importantly, however, this makes the API very hard to use in some bindings languages where rename-imports or module imports aren't available.
Thus, here, we rename both to give them context.