Worlds smallest optimization

[benthecarman]

Preallocate for 6 items in the vec. I chose this value for

1. features
2. description
3. payment hash
4. expire time
5. min_final_cltv
6. payment secret
7. route hint
8. the memes (matt told me to)

[coderabbitai]

Warning

Rate Limit Exceeded

@benthecarman has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 20 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between c93b59e and 0769b22.

Walkthrough

The recent update in the codebase focuses on a specific optimization within the InvoiceBuilder class, where the tagged_fields vector is now pre-initialized with a capacity of 8. This adjustment likely aims to fine-tune memory allocation strategies for potential performance gains.

Changes

File(s)	Change Summary
lightning-invoice/src/lib.rs	Initialized tagged_fields vector with a capacity of 8 in InvoiceBuilder.

🐰🌟
Code optimized, vectors align,
Eight slots now, a change divine.
Efficiency sings in bytes and bits,
With capacity set, performance flits.
🚀🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e0323ec and 3e4c15b.

Files selected for processing (1)

• lightning-invoice/src/lib.rs (1 hunks)

Additional comments: 1

lightning-invoice/src/lib.rs (1)

• 553-553: Preallocating space for six items in the tagged_fields vector is a targeted optimization that aligns with the PR objectives. This change should improve performance by reducing the number of reallocations.

[TheBlueMatt]

Maybe add one for a private route hint and another because 7 is an ugly number and 8 is nicer?

[benthecarman]

Maybe add one for a private route hint and another because 7 is an ugly number and 8 is nicer?

could also do 11 which is the number of tags there are

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c93b59e and 8bf29c6.

Files selected for processing (1)

• lightning-invoice/src/lib.rs (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• lightning-invoice/src/lib.rs

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (36429e8) 89.08% compared to head (3e4c15b) 89.33%.
Report is 8 commits behind head on main.

❗ Current head 3e4c15b differs from pull request most recent head 0769b22. Consider uploading reports for the commit 0769b22 to get more accurate results

Files	Patch %	Lines
lightning/src/blinded_path/mod.rs	88.88%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
+ Coverage   89.08%   89.33%   +0.24%     
==========================================
  Files         115      115              
  Lines       93522    93892     +370     
  Branches    93522    93892     +370     
==========================================
+ Hits        83312    83875     +563     
+ Misses       7673     7603      -70     
+ Partials     2537     2414     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheBlueMatt]

world's smallest ack (i went and checked and this saves exactly one allocation - vec will allocate for 4 on the initial push for reasonable-sized items, and then double)

[TheBlueMatt]

CI fail is unrelated.