Impl clone for ChannelMonitor #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives people more freedom with the channel monitors. For Mutiny this would be nice for us to be able to create copies of them and pass aorund in memory without having to serialize until we actually want to. Originally by benthecarman <benthecarman@live.com> Small bugfix from Matt Corallo <git@bluematt.me>
wpaulino
approved these changes
Jul 24, 2023
| @@ -750,7 +750,14 @@ pub struct ChannelMonitor<Signer: WriteableEcdsaChannelSigner> { | |||
| pub(super) inner: Mutex<ChannelMonitorImpl<Signer>>, | |||
| } | |||
|
|
|||
| #[derive(PartialEq)] | |||
| impl<Signer: WriteableEcdsaChannelSigner> Clone for ChannelMonitor<Signer> where Signer: Clone { | |||
There was a problem hiding this comment.
Nit: just add a + Clone bound, or is there a difference?
There was a problem hiding this comment.
They're equivalent, just gonna leave it the way it was in the original commit.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
- Coverage 90.24% 90.21% -0.03%
==========================================
Files 106 106
Lines 55817 55833 +16
Branches 55817 55833 +16
==========================================
+ Hits 50370 50371 +1
- Misses 5447 5462 +15
☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives people more freedom with the channel monitors. For Mutiny this would be nice for us to be able to create copies of them and pass aorund in memory without having to serialize until we actually want to.
Originally by benthecarman benthecarman@live.com
Small bugfix from Matt Corallo git@bluematt.me
This is just the clone commit from #2331, the ord commit had some debate as to if it should just be a method, and the API for
get_monitorswas debated. Because at least the clone commit was nice, I figured we can just land this and leave the rest for if anyone else wants to do it.