Skip to content

Pin tokio to 1.26 on windows to fix CI #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Mar 10, 2023

We pin tokio to version 1.26 on Windows, which fixes CI on the Rust beta channel.

This raises MSRV for Windows to 1.49, but we only ever had CI jobs for stable and beta anyways.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (23c1b46) 91.14% compared to head (73306a3) 91.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2099   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         101      101           
  Lines       48888    48888           
  Branches    48888    48888           
=======================================
  Hits        44561    44561           
  Misses       4327     4327           

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tnull tnull force-pushed the 2023-03-pin-ntapi-on-windows branch from 5348a99 to 3f7ebdf Compare March 10, 2023 23:41
@tnull
Copy link
Contributor Author

tnull commented Mar 10, 2023

Kicked CI.

TheBlueMatt
TheBlueMatt previously approved these changes Mar 12, 2023
@tnull tnull force-pushed the 2023-03-pin-ntapi-on-windows branch 4 times, most recently from af69ca9 to 3c4ee5c Compare March 12, 2023 13:09
@tnull tnull force-pushed the 2023-03-pin-ntapi-on-windows branch from 3c4ee5c to 73306a3 Compare March 12, 2023 13:12
@TheBlueMatt TheBlueMatt merged commit c18f705 into lightningdevkit:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants